Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove geofield_map? #804

Open
millnut opened this issue Jan 1, 2025 · 2 comments
Open

Can we remove geofield_map? #804

millnut opened this issue Jan 1, 2025 · 2 comments

Comments

@millnut
Copy link
Member

millnut commented Jan 1, 2025

Searching the repo I cannot see it used but it's declared as a dev dependency of localgov

@andybroomfield
Copy link
Contributor

@millnut It was added to resolve an issue with the update test as the original versions of localgov_geo used geofield_map in configuration. See #637 (comment)

Though there is a comment on that about a replacement update test so if that has been removed, so can the dev dependency.

@ekes
Copy link
Member

ekes commented Jan 21, 2025

Be nice not to have to maintain that update for much longer either tbh. It's quite the update. So maybe we could move to dev now, and gone in 'a short while' (bumping localgov geo a minor and removing that update too).

If there's anyone who hasn't updated yet it's probably heading to problematic. And if they haven't they'd have to 1.x 2.0 2.1 which isn't the end of the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants