Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerDeleter does not return information on deleted objects #3373

Open
zacharyDez opened this issue Apr 7, 2021 · 1 comment
Open

LayerDeleter does not return information on deleted objects #3373

zacharyDez opened this issue Apr 7, 2021 · 1 comment

Comments

@zacharyDez
Copy link
Contributor

Description of Request

I have been coming across some difficulties when deleting S3 layers. Having some information on the result of the delete request would be very interesting for implementing additional logic when failures occur.

Proposed Solution

I would like to see the status or even the unsuccessfully deleted objects of the s3Client.deleteObjects request. Something like in the AWS's documentation.

DeleteObjectsResult delObjRes = s3Client.deleteObjects(multiObjectDeleteRequest);
int successfulDeletes = delObjRes.getDeletedObjects().size();

@pomadchin mentionned that all the backends have their corresponding LayerDeleters fand the error encoding should be encoded with all of them.

Describe alternatives you've considered

I am not sure of the direction the effort should take to synchronize all of the backends. I would be happy to contribute to updating the S3 backend.

@pomadchin
Copy link
Member

I'll add an explicit ref to the comment that triggered this issue creation: #3372 (comment)

Thanks for spending some time to make this one! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants