Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EPSG database #4

Closed
willcohen opened this issue Feb 14, 2018 · 6 comments
Closed

Updating EPSG database #4

willcohen opened this issue Feb 14, 2018 · 6 comments

Comments

@willcohen
Copy link
Contributor

What should the process be for updating the EPSG database? proj.4 uses version 9.2 here but I'm not sure how that file should be cited in terms of ownership on this project (especially re the Eclipse CLA).

Moreover, using an updated EPSG database causes the test from #3 to fail again. Would it be acceptable to change the test reprojected value to the one generated by converting the point through PostGIS (which itself uses actual proj.4)?

@dr-jts
Copy link
Contributor

dr-jts commented Feb 14, 2018

Answer to the second question: I think it's acceptable to update the value to whatever value is returned by the new EPSG database (whether from proj4J itself, or some other source). Hopefully it is now correct! (Would be interesting to know why it has changed...)

Also, if the new value is simply less precise, perhaps the test precision should be reduced. (It's always a bit hard to figure out how values should be treated for the more obscure projections).

@dr-jts
Copy link
Contributor

dr-jts commented Feb 14, 2018

For #1 - @lossyrob any ideas

@willcohen
Copy link
Contributor Author

It seems like the epsg and world files in the nad folder are the two things that could use an update, and they come directly from proj.4. If the proj.4 project is, overall, MIT licensed, would it work to just put a reference in LICENSE to proj.4 and that it's MIT? If that sounds good, I can add that and update those two files.

@lossyrob
Copy link
Member

@willcohen yes, updating the database and changing any tests that had previous 'incorrect' values (according to the new DB params) makes a lot of sense. Thanks!

@willcohen
Copy link
Contributor Author

Thanks, just submitted! Also -- for what's it worth, there did seem to be Eclipse IP validation hooks when I submitted PRs #2 and #3, though #7 didn't get one just now.

@lossyrob
Copy link
Member

Closed by #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants