Fixed handling of aggregate extent and image size on geotiff write. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpipkt
reviewed
Sep 23, 2019
| throw new IllegalArgumentException("A destination CRS must be provided") | ||
| ) | ||
|
|
||
| val input = df.asLayerSafely.map(layer => |
There was a problem hiding this comment.
Perhaps add an overload for TileRasterizerAggregate.collect where the type of the first arg is RasterFrameLayer that does some of this work? Feels noisy and implementation-y here.
There was a problem hiding this comment.
Being a layer isn't a precondition for calling this.... just needs a destination CRS, and if one isn't provided attempts to get it from the TLM if the DF is already a layer.
.../src/test/scala/org/locationtech/rasterframes/datasource/geotiff/GeoTiffDataSourceSpec.scala
Show resolved
Hide resolved
.../src/test/scala/org/locationtech/rasterframes/datasource/geotiff/GeoTiffDataSourceSpec.scala
Show resolved
Hide resolved
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### 0.8.2 | |||
|
|
|||
| * Fixed handling of aggregate extent and image size on GeoTIFF writing. ([#362](https://github.com/locationtech/rasterframes/issues/362)) | |||
There was a problem hiding this comment.
Some good citizen clean up things to consider:
Suggested change
| * Fixed handling of aggregate extent and image size on GeoTIFF writing. ([#362](https://github.com/locationtech/rasterframes/issues/362)) | |
| * Bumped Spark dependency to version 2.3.4. #350 | |
| * Fixed handling of aggregate extent and image size on GeoTIFF writing. ([#362](https://github.com/locationtech/rasterframes/issues/362)) |
vpipkt
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360