-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutation search should have full advanced query support #1398
Comments
Can we not do this even by API? |
Pretty sure we can there - GenSpectrum uses LAPIS too |
Yes we can if we add a text field, the current mutation search tries to be fancy with the little cards that are added, which looks nice but is complicated to extend to anything but the most basic "all mutations required" query |
IMO it's perfect for MVP (not saying you're disagreeing). I think when we have time the search form needs a fair bit of UX-rework of the sort we've done elsewhere, which could include this |
The advanced variant query has not been generalized yet and is currently only available if you activate a special SARS-CoV-2 flag. In principle, we can get something working quite quickly but I would also suggest discussing it post-MVP. |
@corneliusroemer, this is currently not implemented in LAPIS, so I'd like to confirm whether you really think that this is high priority or whether the sub-lineage search #3074 would suffice. |
It's not very useful to be able to search just for the presence of all of a list of mutations on its own.
LAPIS supports much more, like
[3-of:]
or absence of mutations like!1234C
. The current mutation search doesn't support that, limiting usefulness.If we're going down that route, it would be nice to also allow inclusion of metadata fields in the search queries, e.g.
country:Germany | country:USA
.Though it might be easier to set up a dedicated Genspectrum for everything including mutation queries.
The text was updated successfully, but these errors were encountered: