Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests for loading fasta are failing (pretty consistently) #1663

Closed
anna-parker opened this issue Apr 26, 2024 · 0 comments · Fixed by #1664
Closed

e2e tests for loading fasta are failing (pretty consistently) #1663

anna-parker opened this issue Apr 26, 2024 · 0 comments · Fixed by #1664
Labels
bug Something isn't working website Tasks related to the web application
Milestone
MVP

Comments

@anna-parker
Copy link
Contributor

I noticed that I get this failure when I run the tests locally on main. My recent PR had the same issue and also other recent PRs. From the looks of things we have somehow inserted an additional \n into the fasta output.

image
@anna-parker anna-parker added the bug Something isn't working label Apr 26, 2024
This was referenced Apr 26, 2024
Merged
Merged
@chaoran-chen chaoran-chen moved this to Backlog in Planning Apr 26, 2024
@chaoran-chen chaoran-chen added this to the MVP (public) milestone Apr 26, 2024
@chaoran-chen chaoran-chen added the website Tasks related to the web application label Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Planning Apr 26, 2024
@theosanderson theosanderson mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working website Tasks related to the web application
Projects
Planning
Archived in project
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Fix e2e test failures when reading fasta file. loculus-project/loculus
2 participants
@chaoran-chen @anna-parker