Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Log Viewer to Modern UI #2437

Closed
2 tasks done
andrewbaldwin44 opened this issue Oct 27, 2023 · 1 comment · Fixed by #2440
Closed
2 tasks done

Add Log Viewer to Modern UI #2437

andrewbaldwin44 opened this issue Oct 27, 2023 · 1 comment · Fixed by #2440

Comments

@andrewbaldwin44
Copy link
Collaborator

Prerequisites

Description

Proposed Solution

  • Expose a new route from web.py /log, which will return all of the applications logs in JSON format
  • Add a new tab to the modern web UI that will fetch and display the logs

Implementation

There are two possible implementations:

  1. Using logfiles:
    • The logs are outputted to a file when the --logfile option is set
    • The /log resource can then read from this logfile and return the output in JSON format
  2. Using a new handler:
    • Add a custom log handler that keeps track of all application logs
    • The /log resource would then read from this custom handler

The one complexity will be if we want to display worker logs as well we will need to setup new event handlers so that the worker can report their logs to master

@cyberw
Copy link
Collaborator

cyberw commented Oct 27, 2023

Second option sounds better to me. Perhaps we need to limit the amount of data held in the buffer though (something like 1000 log messages could be a reasonable default)

Worker logs would be nice too of course, but that can be step two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants