Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate using lodash babel plugin #5570

Closed
trajano opened this issue Dec 12, 2022 · 2 comments
Closed

Deprecate using lodash babel plugin #5570

trajano opened this issue Dec 12, 2022 · 2 comments
Labels
issue bankruptcy Closing the issue/PR to start fresh

Comments

@trajano
Copy link

trajano commented Dec 12, 2022

Since package.json has indicated the module is sideEffect: false there shouldn't be a need for the babel plugin anymore as tree shaking will remove the unused portions.

I have at least verified this to be the case in Expo when I did eas update and I got the same package size with the plugin and without the plugin enable.
@trajano trajano mentioned this issue Dec 12, 2022
Open
@jdalton
Copy link
Member

jdalton commented Jan 4, 2023

Nice!

@denkristoffer
Copy link

The babel plugin is still necessary if you use lodash/fp, otherwise you end up with both lodash.js and lodash.min.js in your bundle.

See #3079 and lodash/babel-plugin-lodash#243

@jdalton jdalton added the issue bankruptcy Closing the issue/PR to start fresh label Sep 16, 2023
@jdalton jdalton closed this as completed Sep 16, 2023
@jcoyne jcoyne mentioned this issue Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue bankruptcy Closing the issue/PR to start fresh
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdalton @trajano @denkristoffer