Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider creating automated tests #128

Open
olebole opened this issue Apr 15, 2020 · 2 comments
Open

Please consider creating automated tests #128

olebole opened this issue Apr 15, 2020 · 2 comments

Comments

@olebole
Copy link
Contributor

olebole commented Apr 15, 2020

Hi,

since it seems that PyBDSF is one of the popular packages of KERN (@gijzelaerr reported about this), I am thinking about packaging it for Debian based on the KERN package.

One of the things that would help me a lot were automated tests, with pytest or so:

  1. They could be run during package build, ensuring that the package works well on all our supported platforms

  2. They could be run regularly on the installed package to ensure that it works in the evolving environment of Debian (new versions of astropy, scipy etc.).

The tests that are in the test subdirectory seem to be interactive, right? Would it be possible to add some automated tests?

@tammojan
Copy link
Collaborator

The test tbdsf_process_image.py is not interactive, and as far as I know tests a lot of functionality. At the very least, it often breaks (usually at boost linking problems), so I've found it a useful test.

@tammojan
Copy link
Collaborator

While the tests are arguably not proper, they are run regularly on travis, see https://github.com/lofar-astron/PyBDSF/blob/master/.travis.yml#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants