Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/revisit MacOS parsers and plugins #1888

Closed
1 task
Onager opened this issue May 18, 2018 · 6 comments
Closed
1 task

Refactor/revisit MacOS parsers and plugins #1888

Onager opened this issue May 18, 2018 · 6 comments
Assignees
@joachimmetz
Labels
code health Non-functional changes to improve code health MacOS Issue related to MacOS parsers Issues related to parsers and parser plug-ins

Comments

@Onager
Copy link
Contributor

Onager commented May 18, 2018 •
edited
Loading

Many of the MacOS parsers and plugins have been minimally updated to be compatible with core changes. It would be useful to see if there are more structural changes that would be helpful.

Specific things to look at:

  • Error handling in macuser plist plugin
@Onager Onager added the code health Non-functional changes to improve code health label May 18, 2018
@joachimmetz
Copy link
Member

@Onager with "MacOS parsers and plugins" are you referring to the plist parser plugins or also other ones?

@joachimmetz joachimmetz added the parsers Issues related to parsers and parser plug-ins label May 20, 2018
@Onager
Copy link
Contributor Author

Onager commented May 20, 2018

Others as well, last time I looked at BSM it looked a little papered-over. I haven't made an exhaustive list of what needs to be done yet though.

@joachimmetz
Copy link
Member

Ack, if BSM uses construct (I did not check), it will surface in #1893 as well

@joachimmetz
Copy link
Member

Yes BSM uses construct, I opt to make a list (be it a first draft) and determine what needs to be done and what could overlap with #1893

@pstirparo pstirparo added the MacOS Issue related to MacOS label Aug 30, 2018
@joachimmetz
Copy link
Member

@Onager is there still work to be done on this issue? if so please update the issue with the details of what needs to be done, if not please close.

@joachimmetz joachimmetz added this to the 2019 May release milestone May 12, 2019
@Onager Onager added the clean up issue Issue that needs to be clarified, or split into other issues label May 30, 2019
@Onager Onager removed this from the 2019 May release milestone May 30, 2019
@joachimmetz joachimmetz removed the clean up issue Issue that needs to be clarified, or split into other issues label May 16, 2021
@joachimmetz joachimmetz self-assigned this May 16, 2021
@joachimmetz
Copy link
Member

Considering this issue addressed. Create a new issue if there are specific things remaining in line of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmetz joachimmetz

Labels
code health Non-functional changes to improve code health MacOS Issue related to MacOS parsers Issues related to parsers and parser plug-ins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Onager @pstirparo @joachimmetz