Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirefoxCacheParser skips blocks #2066

Closed
joachimmetz opened this issue Aug 1, 2018 · 2 comments
Closed

FirefoxCacheParser skips blocks #2066

joachimmetz opened this issue Aug 1, 2018 · 2 comments
Assignees
Labels
bug parsers Issues related to parsers and parser plug-ins

Comments

@joachimmetz
Copy link
Member

https://github.com/log2timeline/plaso/blob/master/plaso/parsers/firefox_cache.py#L309

    # A request can span multiple blocks, so we use modulo.
    file_offset = file_object.get_offset() - offset
    _, remainder = divmod(file_offset, block_size)

    # Move reader to next candidate block. Include the null-byte skipped above.
    file_object.seek(block_size - remainder, os.SEEK_CUR)

does not account for a remainder of 0

@joachimmetz joachimmetz self-assigned this Aug 1, 2018
@joachimmetz joachimmetz added bug parsers Issues related to parsers and parser plug-ins labels Aug 1, 2018
@joachimmetz
Copy link
Member Author

Pending changes in #2070

@joachimmetz joachimmetz added this to the 2018 August release milestone Aug 18, 2018
@joachimmetz
Copy link
Member Author

Fixed with changes for migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug parsers Issues related to parsers and parser plug-ins
Projects
None yet
Development

No branches or pull requests

1 participant