implemented DateLessLogFormatHelper #4699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4699 +/- ##
========================================
Coverage 85.24% 85.25%
========================================
Files 426 427 +1
Lines 38532 38643 +111
========================================
+ Hits 32847 32944 +97
- Misses 5685 5699 +14 ☔ View full report in Codecov by Sentry. |
joachimmetz
force-pushed
the
dateless
branch
from
8921705 to
bc63df0
Compare
joachimmetz
force-pushed
the
dateless
branch
from
bc63df0 to
8b20862
Compare
joachimmetz
reviewed
Feb 20, 2024
joachimmetz
reviewed
Feb 20, 2024
|
@rick-slin FYI I'll start looking at merging this after the March release I might combine it with the yearless log helper into 1 |
…iest_date and latest_date, added tests for dateless_helper
joachimmetz
reviewed
Mar 23, 2024
joachimmetz
reviewed
Mar 23, 2024
joachimmetz
reviewed
Mar 23, 2024
joachimmetz
reviewed
Mar 23, 2024
joachimmetz
reviewed
Mar 23, 2024
|
@rick-slin unfortunately there are some shortcomings in the current design/approach, I'll need to take a closer look at a later time how to best implement support for date and time formats without a date. |
joachimmetz
added
the
blocked
|
Closing in favor of #4851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of pull request
Implemented DateLessLogFormatHelper to retreive a date based on the modified, changed and creation time of a file.
Description:
Implemented DateLessLogFormatHelper to retreive a date based on the modified, changed and creation time of a file.
Related issue (if applicable): fixes #4697
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: