Make mdapi conversion the default mode

Retrieving a changeset downloads all the components along with it. Converting the metadata that we already have will save us having to kick off another retrieve from salesforce, and hopefully save a bit of time.

The source mode will stay around until we need it, or prove that we don't need it.

Author: loganm

src/commands/changeset/retrieve.ts

@@ -45,24 +45,24 @@ export default class Retrieve extends SfdxCommand {
     const pkgBuf = await this.retrieveChangeset(conn, changesetname);
     this.ux.stopSpinner('Done!');
 
-    if (mode == 'convert') {
-      this.ux.startSpinner('Extracting Package');
+    if (mode == 'source') {
+      this.ux.startSpinner('Extracting package.xml');
       let zip = new AdmZip(pkgBuf);
-      await zip.extractAllTo(`changesets/${changesetname}`, true);
+      await zip.extractEntryTo(`${changesetname}/package.xml`, `changesets`, true, true);
       this.ux.stopSpinner('Done!');
 
-      this.ux.startSpinner('Converting to Source');
-      await runCommand(`sfdx force:mdapi:convert -r changesets/${changesetname}`);
+      this.ux.startSpinner('Retrieving Source');
+      await runCommand(`sfdx force:source:retrieve -u ${username} -x changesets/${changesetname}/package.xml`);
       this.ux.stopSpinner('Done!');
     }
     else {
-      this.ux.startSpinner('Extracting package.xml');
+      this.ux.startSpinner('Extracting Package');
       let zip = new AdmZip(pkgBuf);
-      await zip.extractEntryTo(`${changesetname}/package.xml`, `changesets`, true, true);
+      await zip.extractAllTo(`changesets`, true);
       this.ux.stopSpinner('Done!');
 
-      this.ux.startSpinner('Retrieving Source');
-      await runCommand(`sfdx force:source:retrieve -u ${username} -x changesets/${changesetname}/package.xml`);
+      this.ux.startSpinner('Converting to Source');
+      await runCommand(`sfdx force:mdapi:convert -r changesets/${changesetname}`);
       this.ux.stopSpinner('Done!');
     }