Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_final callback removed #9

Open
lgfa29 opened this issue Apr 9, 2019 · 2 comments
Open

_final callback removed #9

lgfa29 opened this issue Apr 9, 2019 · 2 comments

Comments

@lgfa29
Copy link

lgfa29 commented Apr 9, 2019

A while back I submitted a PR to fix Winston 3 support, but part of my PR was removed, more specifically that part that implemented the _final callback to flush messages when the transport closes.

I added a comment to the commit but it seems to not have enough visibility.

Would it possible to get the _final callback back in place? It's extremely import in my use case where I am using Open Whisk so I need to flush the messages before my action gets terminated and I lose important log messages.

Thank you.

@lgfa29
Copy link
Author

lgfa29 commented Apr 9, 2019

For more information on _final in Winston, check winstonjs/winston#1346 and https://github.com/winstonjs/winston-transport/pull/24/files

@lgfa29
Copy link
Author

lgfa29 commented Jun 3, 2019

@respectus @LYHuang any chance someone could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant