Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated LogstashMarker#with() #615

Closed
brenuart opened this issue Aug 20, 2021 · 2 comments
Closed

Remove deprecated LogstashMarker#with() #615

brenuart opened this issue Aug 20, 2021 · 2 comments
Labels
status/invalid

Comments

@brenuart
Copy link
Collaborator

Time to remove the deprecated LogstashMarker#with(Marker) method before releasing version 7.0
@brenuart brenuart added the warn/api-change Breaking change with compilation or xml configuration errors label Aug 20, 2021
@philsttr
Copy link
Collaborator

philsttr commented Aug 20, 2021 •
edited
Loading

I'd prefer to not remove with in 7.0, since 6.6 documentation still references it (fixed in #463 in 7.0), and since it could be prevalent in app code (see #470 (comment)). It's a pretty small method, so there is not any maintenance overhead in keeping it around a bit longer.

@brenuart brenuart added status/invalid and removed warn/api-change Breaking change with compilation or xml configuration errors labels Aug 24, 2021
@brenuart
Copy link
Collaborator Author

Ok - leave it for now. Closing issue with status "invalid".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brenuart @philsttr