feat(notifications): use chakra notifications #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snqb
commented
May 3, 2023
snqb
commented
ehsan-github
reviewed
May 4, 2023
snqb
force-pushed
the
feat/notifications-revamp
branch
from
56eaf98 to
6f0199e
Compare
snqb
changed the title
snqb
commented
May 10, 2023
| @@ -10,7 +10,6 @@ const config: StorybookConfig = { | |||
| '@storybook/addon-essentials', | |||
| '@storybook/addon-interactions', | |||
| 'storybook-dark-mode', | |||
| '@chakra-ui/storybook-addon', | |||
There was a problem hiding this comment.
it added no value and rendered a second dark mode button which didn't work fine, because we have chakra+rebass :(
ehsan-github
approved these changes
May 10, 2023
ehsan-github
pushed a commit
that referenced
this pull request
May 10, 2023
# [2.4.0](v2.3.0...v2.4.0) (2023-05-10) ### Features * **notifications:** use chakra notifications ([#384](#384)) ([4a032a2](4a032a2))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.