Actually initialize the transport client as the correct impl class

Author: andrewvc

lib/logstash/outputs/elasticsearch_java/protocol.rb

@@ -14,12 +14,6 @@ def initialize(options={})
             @logger = Cabin::Channel.get
           end
 
-          def client
-            return @client if @client
-            @client = build_client(@options)
-            return @client
-          end
-
           def template_install(name, template, force=false)
             if template_exists?(name) && !force
               @logger.debug("Found existing Elasticsearch template. Skipping template management", :name => name)
@@ -236,6 +230,13 @@ def template_put(name, template)
         end # class NodeClient
 
         class TransportClient < NodeClient
+          def client
+            return @client if @client
+            @client = build_client(@options)
+            return @client
+          end
+
+
           private
           def build_client(options)
             client = org.elasticsearch.client.transport.TransportClient.

spec/integration/outputs/transport_create_spec.rb

@@ -29,6 +29,12 @@ def get_es_output(action, id = nil)
   end
 
   context "when action => create" do
+    it "should instantiate a transport, not node, client" do
+      subject = get_es_output("create", "id123")
+      subject.register
+      expect(subject.client.send(:client).class).to eql(Java::OrgElasticsearchClientTransport::TransportClient)
+    end
+
     it "should create new documents with or without id" do
       subject = get_es_output("create", "id123")
       subject.register