-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the :arguments option actually used in the plugin? #44
Comments
i was also curious about it. arguments and passive options are queue-specific, though no queue name could be provided and no queue-specific logic exists not in output nor in plugin. from the history, it seems that both options was created on initial commit of the mixin (https://github.com/logstash-plugins/logstash-mixin-rabbitmq_connection/pull/1/files#diff-5a4e6da9864c64f906837378a6f551e6R56) which was "Pulled from the rabbitmq output sources. Modified to be a mixin." by @andrewvc , though no such logic nor option itself was not present in the original output... (relevant commit: bea6ebf) Those options are used though in logstash-input-plugin... |
Apologies here, this seems to have just been an artifact of that being legacy code. I'll try and take a look at it this week. |
Is there a fix in progress for this issue? |
This is turning into a long week.. |
I was currently testing the arguments option of the rabbitmq output plugin.
Specifically, i tried the 'x-max-length' option like this:
But after checking in the rabbitmq management interface the option doesn't seem to be honored. A quick check at the source code (https://github.com/logstash-plugins/logstash-output-rabbitmq/blob/master/lib/logstash/outputs/rabbitmq.rb and https://github.com/logstash-plugins/logstash-mixin-rabbitmq_connection/blob/master/lib/logstash/plugin_mixins/rabbitmq_connection.rb) suggests, that the :argument option is not used in the code, or did I miss anything?
The text was updated successfully, but these errors were encountered: