-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): init and add sign in route handler #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangsijie
force-pushed
the
sijie-log-3588-node-sdk
branch
from
July 14, 2022 03:43
c89d8b7
to
ad9c073
Compare
wangsijie
force-pushed
the
sijie-log-3580-init-next
branch
from
July 14, 2022 03:46
61646a6
to
62cf92c
Compare
wangsijie
force-pushed
the
sijie-log-3588-node-sdk
branch
3 times, most recently
from
July 14, 2022 06:17
cfcfed2
to
81481ea
Compare
wangsijie
force-pushed
the
sijie-log-3580-init-next
branch
2 times, most recently
from
July 14, 2022 07:46
43f811d
to
792ae85
Compare
wangsijie
requested review from
darcyYe,
charIeszhao,
gao-sun,
IceHe,
simeng-li and
xiaoyijun
July 14, 2022 07:47
wangsijie
force-pushed
the
sijie-log-3580-init-next
branch
3 times, most recently
from
July 15, 2022 06:04
f4460a8
to
87822f9
Compare
wangsijie
changed the title
feat(next): init and sign in route
feat(next): init and add sign in route handler
Jul 15, 2022
charIeszhao
reviewed
Jul 15, 2022
charIeszhao
reviewed
Jul 15, 2022
charIeszhao
reviewed
Jul 15, 2022
gao-sun
reviewed
Jul 16, 2022
gao-sun
reviewed
Jul 16, 2022
wangsijie
force-pushed
the
sijie-log-3580-init-next
branch
from
July 18, 2022 03:26
87822f9
to
0d518cb
Compare
gao-sun
reviewed
Jul 18, 2022
wangsijie
force-pushed
the
sijie-log-3580-init-next
branch
from
July 18, 2022 05:55
0d518cb
to
04abe94
Compare
gao-sun
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good @demonzoo can double check if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement "Sign In" handler, when visiting "/api/sign-in", the user will be redirect to generated sign in uri (to Logto).
check "next-sample" for usage, if you are not familar with NextJS.
Testing
UTs