feat(client): persist access token #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangsijie
requested review from
IceHe,
xiaoyijun,
charIeszhao,
gao-sun,
darcyYe and
simeng-li
wangsijie
force-pushed
the
sijie-persist-access-token
branch
from
42158eb
to
e5e8edc
Compare
charIeszhao
reviewed
Jul 20, 2022
charIeszhao
reviewed
Jul 20, 2022
charIeszhao
approved these changes
Jul 20, 2022
wangsijie
force-pushed
the
sijie-persist-access-token
branch
from
e5e8edc
to
ff71d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional feature: persist access token to storage.
Before this, access token is only saved in instance property, when creating a new instance, it doesn't have any access token, but it can reuse refresh token from storage, and then grant a new access token. This is fine for SPA, since it only have an instance when the user navigates between pages. But in other circumstances, especially in traditional app when LogtoClient is run in server side, it will create a new instance each time when receiving a request, that means there will be so many instances sharing the same storage. Then, it'll be good to reuse access token.
Testing
UTs.