Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove persist access token #406

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix: remove persist access token #406

merged 1 commit into from
Sep 20, 2022

Conversation

wangsijie
Copy link
Contributor

Summary

Remove persistAccessToken from configs, it is no longer configuable.

Testing

UTs

@wangsijie wangsijie requested a review from a team September 19, 2022 10:24
@linear
Copy link

linear bot commented Sep 19, 2022

LOG-4103 JS Client SDK: Remove the persistAccessToken from LogtoConfig

simeng-li
simeng-li approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsijie wangsijie merged commit f2ba84f into master Sep 20, 2022
@wangsijie wangsijie deleted the sijie-log-4103-persist-at branch September 20, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeng-li simeng-li simeng-li approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangsijie @simeng-li