Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-sample): use location assign for sign in redirect #465

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(next-sample): use location assign for sign in redirect #465

merged 1 commit into from
Mar 31, 2023

Conversation

wangsijie
Copy link
Contributor

Summary

According to NextJs official doc, client-side transitions between routes can be enabled via the Link component.

In this case, "sign in" is not an internal route, it'll cause CORS issue because NextJS will perform some "pre-render".

Use location.assign instead.

Testing

Local tested.

Checklist

  • .changset-staged
  • unit tests
  • integration tests
  • docs

OR

  • This PR is not applicable for the checklist

@wangsijie wangsijie requested a review from a team March 30, 2023 03:16
@wangsijie wangsijie mentioned this pull request Mar 30, 2023
Closed
@wangsijie wangsijie merged commit 6286eff into master Mar 31, 2023
@wangsijie wangsijie deleted the sijie-fix-next-sample-sign-in branch March 31, 2023 03:47
@silverhand-bot silverhand-bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyijun xiaoyijun xiaoyijun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangsijie @xiaoyijun