fix(connector): fix Aliyun SMS connector error handling #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
wangsijie,
IceHe,
xiaoyijun,
charIeszhao,
gao-sun and
simeng-li
LOG-3201 Fix Aliyun SMS error handling
阿里云短信请求的返回值有些奇怪，有些错误会正常返回 response，解析 response body 之后通过 查看 code 能知道错误信息；同时有的时候也会直接在请求时抛错，这两种情况都要考虑。 之前没有发现会在请求时直接抛错的情况。 |
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/connector-aliyun-sms/src/index.ts | 📈 +776 Bytes |
IceHe
reviewed
Jun 24, 2022
|
What's the status of this? |
darcyYe
force-pushed
the
yemq-log-3201-aliyun-sms-error-handling
branch
from
c0b4685
to
5a0282c
Compare
darcyYe
force-pushed
the
yemq-log-3201-aliyun-sms-error-handling
branch
from
0182dee
to
b5c594d
Compare
darcyYe
changed the title
wangsijie
reviewed
Jul 5, 2022
wangsijie
reviewed
Jul 6, 2022
wangsijie
requested changes
Jul 6, 2022
wangsijie
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix error handling of requesting SmsSend API.
Testing
UTs.