Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): user settings unsaved changes alert #1411

Merged

Conversation

xiaoyijun
Copy link
Contributor

Summary

feat(console): user settings unsaved changes alert

Testing

image

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

COMPARE TO master

Total Size Diff 📈 +380 Bytes

Diff by File
Name Diff
packages/console/src/pages/UserDetails/components/UserLogs.tsx 📈 +343 Bytes
packages/console/src/pages/UserDetails/components/UserSettings.tsx 📈 +4.69 KB
packages/console/src/pages/UserDetails/index.tsx 📈 +4.66 KB

@xiaoyijun xiaoyijun marked this pull request as draft July 5, 2022 03:00
@xiaoyijun xiaoyijun marked this pull request as ready for review July 5, 2022 03:07
@xiaoyijun xiaoyijun marked this pull request as draft July 5, 2022 06:17
Base automatically changed from xiaoyijun-log-2257-unsaved-alert to master July 5, 2022 09:09
@xiaoyijun xiaoyijun force-pushed the xiaoyijun-feat-user-settings-unsaved-changes-alert branch from e9c9b70 to fa97d70 Compare July 5, 2022 09:26
@xiaoyijun xiaoyijun marked this pull request as ready for review July 5, 2022 09:26
@xiaoyijun xiaoyijun force-pushed the xiaoyijun-feat-user-settings-unsaved-changes-alert branch from fa97d70 to 407d805 Compare July 6, 2022 07:54
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoyijun xiaoyijun merged commit 14b27b6 into master Jul 6, 2022
@xiaoyijun xiaoyijun deleted the xiaoyijun-feat-user-settings-unsaved-changes-alert branch July 6, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants