feat(connector): connector error handler, throw errmsg on general errors #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOG-3239 Connector Error Exposure
对于有些配置上的错误，需要暴露具体信息 (error_code, error_description)。 不能放在 RequestError.data 里。可以是定义一个特殊的错误码或者类型，让外部特殊处理。 |
darcyYe
requested review from
IceHe,
wangsijie,
charIeszhao,
gao-sun,
simeng-li and
xiaoyijun
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/connector-alipay-native/src/constant.ts | 📈 +114 Bytes |
| packages/connector-alipay-native/src/index.test.ts | 📈 +136 Bytes |
| packages/connector-alipay-native/src/index.ts | 📈 +190 Bytes |
| packages/connector-alipay-native/src/types.ts | 📈 +48 Bytes |
| packages/connector-alipay/src/constant.ts | 📈 +114 Bytes |
| packages/connector-alipay/src/index.test.ts | 📈 +144 Bytes |
| packages/connector-alipay/src/index.ts | 📈 +257 Bytes |
| packages/connector-alipay/src/types.ts | 📈 +38 Bytes |
| packages/connector-aliyun-dm/src/index.ts | 📈 +303 Bytes |
| packages/connector-aliyun-dm/src/types.ts | 📈 +36 Bytes |
| packages/connector-aliyun-sms/src/index.ts | 📈 +363 Bytes |
| packages/connector-facebook/src/index.test.ts | 📈 +17 Bytes |
| packages/connector-facebook/src/index.ts | 📈 +263 Bytes |
| packages/connector-github/src/index.ts | 📈 +195 Bytes |
| packages/connector-google/src/index.ts | 📈 +167 Bytes |
| packages/connector-twilio-sms/src/types.ts | 📈 +80 Bytes |
| packages/connector-wechat-native/src/constant.ts | 📈 +272 Bytes |
| packages/connector-wechat-native/src/index.test.ts | 📈 +258 Bytes |
| packages/connector-wechat-native/src/index.ts | 📈 +147 Bytes |
| packages/connector-wechat/src/constant.ts | 📈 +272 Bytes |
| packages/connector-wechat/src/index.test.ts | 📈 +258 Bytes |
| packages/connector-wechat/src/index.ts | 📈 +148 Bytes |
| packages/core/src/middleware/koa-connector-error-handler.test.ts | 📈 +613 Bytes |
| packages/core/src/middleware/koa-connector-error-handler.ts | 📈 +332 Bytes |
| packages/phrases/src/locales/en.ts | 📈 +20 Bytes |
| packages/phrases/src/locales/zh-cn.ts | 📈 +20 Bytes |
gao-sun
reviewed
Jul 7, 2022
gao-sun
reviewed
Jul 7, 2022
|
also, remember to use squash merge :-) |
wangsijie
reviewed
Jul 8, 2022
darcyYe
force-pushed
the
yemq-log-3239-expose-connector-error
branch
from
eff132a
to
3df948c
Compare
gao-sun
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
looks good to me. but @wangsijie would have more context. better to have another stamp
gao-sun
changed the title
wangsijie
approved these changes
Jul 8, 2022
darcyYe
force-pushed
the
yemq-log-3239-expose-connector-error
branch
from
3decf09
to
ba3e3aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update connector error handler, throw error description on General errors.
Testing
UTs and tested locally.