Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): connector placeholder icon should not have background color #1472

Merged

Conversation

xiaoyijun
Copy link
Contributor

Summary

fix(console): connector placeholder icon should not have background color

Testing

image

image

@linear
Copy link

linear bot commented Jul 8, 2022

LOG-3496 Fix SMS & Email Connector Avatar

截屏2022-07-07 下午2.37.41.png

Connector avatart底色套了两层

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

COMPARE TO master

Total Size Diff 📉 -1.3 KB

Diff by File
Name Diff
packages/console/src/assets/images/connector-email.svg 📉 -132 Bytes
packages/console/src/assets/images/connector-sms.svg 📉 -177 Bytes
packages/console/src/consts/connectors.ts 📉 -353 Bytes
packages/console/src/pages/Connectors/components/ConnectorName/index.tsx 📉 -26 Bytes
packages/console/src/pages/Connectors/components/ConnectorPlaceholderIcon/index.tsx 📉 -695 Bytes

Copy link
Contributor

@IceHe IceHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoyijun xiaoyijun merged commit 130817f into master Jul 8, 2022
@xiaoyijun xiaoyijun deleted the xiaoyijun-log-3496-fix-sms-email-connector-avatar branch July 8, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants