Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo-app): username should not overflow info card #1498

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix(demo-app): username should not overflow info card #1498

merged 1 commit into from
Jul 8, 2022

Conversation

charIeszhao
Copy link
Member

Summary

Long username will no longer overflow the outer card

image

Testing

  • Tested locally

@charIeszhao charIeszhao self-assigned this Jul 8, 2022
@linear
Copy link

linear bot commented Jul 8, 2022

LOG-3497 [AC] Demo App 完成页的超长Username会爆框，考虑限制Username字符数 / 折行显示完整

image.png

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

COMPARE TO master

Total Size Diff 📈 +109 Bytes

Diff by File
Name Diff
packages/demo-app/src/App.module.scss 📈 +109 Bytes

@gao-sun gao-sun merged commit 58558e5 into master Jul 8, 2022
@gao-sun gao-sun deleted the charles-log-3497-demo-app-text-overflow-issue branch July 8, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gao-sun gao-sun gao-sun approved these changes

@wangsijie wangsijie Awaiting requested review from wangsijie

@IceHe IceHe Awaiting requested review from IceHe

@xiaoyijun xiaoyijun Awaiting requested review from xiaoyijun

@darcyYe darcyYe Awaiting requested review from darcyYe

@simeng-li simeng-li Awaiting requested review from simeng-li

Assignees

@charIeszhao charIeszhao

Labels
bugfix size/xs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charIeszhao @gao-sun