Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with JSX highlighting #15

Closed
Grawl opened this issue Jan 7, 2020 · 4 comments
Closed

Problem with JSX highlighting #15

Grawl opened this issue Jan 7, 2020 · 4 comments

Comments

@Grawl
Copy link
Contributor

Grawl commented Jan 7, 2020

When I see Client Example, there is a problem with JSX highlighting:

изображение

With github theme in 9.17.1 version it should look like this:

изображение

I created a Codepen sandbox to see how it should work.

I checked out what version of Highlight.js is used in project and it's latest one:

➜ cat node_modules/highlight.js/package.json | grep version
  "version": "9.17.1",
@ai
Copy link
Member

ai commented Jan 7, 2020

Will Prism.js solve the problem?

@Grawl
Copy link
Contributor Author

Grawl commented Jan 8, 2020

looks like we're facing highlightjs/highlight.js#931 and this issue is solved in Highlight.js.

Prism can also solve our problem.

@ai
Copy link
Member

ai commented Jan 8, 2020

Do you want to try to replace highlighter and get some experience with my fancy build system?

Here we call a highlighter https://github.com/logux/logux.io/blob/master/scripts/steps/read-docs.js#L212-L215

You can test highlighter by calling:

yarn build
npx ssdeploy run

(You can keep ssdeploy running in the background and rebuild HTML files by calling yarn build again, Docker will load changes into nginx)

@ai
Copy link
Member

ai commented May 27, 2020

Closing it for now, since I will not have time for it

@ai ai closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants