-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "BaGet.Core.Server" to "BaGet.AspNetCore" #344
Comments
I have vendored this excellent project into my own code base and extended with some bits and bobs that is needed to service internal enterprise environments. |
Hi @michael-baker, thank you for your reply!
That makes sense, and I apologize for the churn this will introduce. I'd like to make it easy to add BaGet to an existing ASP.NET Core project. This will let advanced customers like you customize BaGet to their hearts desire (Want to set HSTS headers? Want to read configs from Azure Key Vault?). I will need to do some breaking changes to enable this experience. I hope that makes sense, but please let me know if you have any feedback! I'd like to reach BaGet v1 "soon"-ish, at which point I will lock down BaGet's public APIs.
What kind of extensions have you added to BaGet? Is there anything you'd like me to add into BaGet? |
I don't believe my modifications are general purpose enough to warrant inclusion in the core product. I realize I could add these features with a front end, gateway and a million other ways but I decided to just modify the projects directly. I added support for
I'll merge the the rename changes into my fork when it becomes available :) |
Wow that's impressive.
Did you add a NuGet client authentication plugin to support these? Why do you need both certificate authentication and Azure Active Directory?
How do you route clients - does the web front end redirect to the correct blob storage? How do you keep all your blob storage accounts up-to-date? I'd love to learn more about your scenario! Would you be up to chat on Skype or something? :) |
Addressed in #678 |
Also improve description "Controllers and routing" etc..
This blocks #396
The text was updated successfully, but these errors were encountered: