Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not convert emoji #2

Closed
kpocius opened this issue Oct 17, 2022 · 2 comments
Closed

Do not convert emoji #2

kpocius opened this issue Oct 17, 2022 · 2 comments
Assignees
@longkai
Labels
enhancement New feature or request

Comments

@kpocius
Copy link

kpocius commented Oct 17, 2022

Not sure if this is a bug or a feature request and whether it's actually an issue with the upstream, but the extension messes with the code if there are emojis in it.

For example:

- test: |
    🔥

Becomes:

- test: "\U0001F525\n"

This is particularly a problem if you have complex scripts that include emojis -- it converts the entire thing into a single-line string.
@longkai
Copy link
Owner

longkai commented Oct 18, 2022 •
edited
Loading

Thanks for the feedback!

I investigated and found how to implement it. Wait for the next release!

@longkai longkai added the enhancement New feature or request label Oct 18, 2022
@longkai longkai self-assigned this Oct 18, 2022
@longkai
Copy link
Owner

longkai commented Oct 19, 2022

Just released 1.1.0 to the marketplace, thanks for the feedback!

@longkai longkai closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longkai longkai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longkai @kpocius