Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation incorrectly fails for modifiers when using $currentDate #424

Closed
brent-hoover opened this issue Jan 20, 2021 · 2 comments
Closed

Comments

@brent-hoover
Copy link

brent-hoover commented Jan 20, 2021

The following code:

import SimpleSchema from 'simpl-schema';

const PersonSchema = new SimpleSchema({
	name: String,
	age: Number,
	updatedAt: Date
});

const modifier = {
	$set: { name: "frank" },
	$currentDate: { updatedAt: true }
};


PersonSchema.validate(modifier, { modifier: true });

throws

errorType: 'ClientError',
error: 'validation-error',
details: [
  {
    name: 'updatedAt',
    value: true,
    type: 'expectedType',
    dataType: 'Date',
    message: 'Updated at must be of type Date'
  }
]

but it is a valid mongo modifier: https://docs.mongodb.com/manual/reference/operator/update/currentDate/

@github-actions
Copy link

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

@brent-hoover brent-hoover changed the title Schema validation incorrectly fails for modifiers when using $currentDate Schema validation incorrectly fails for modifiers when using $currentDate Jan 20, 2021
@aldeed
Copy link
Collaborator

aldeed commented Apr 8, 2021

Hi @zenweasel! 1.11.1 now has basic support for the $currentDate modifier. It's treated properly when cleaning the object, and it won't fail the checks during validation. I can't guarantee it will work in all possible circumstances, but should be better. Please create a new issue if you have problems with it on 1.11.1.

@aldeed aldeed closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants