Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0: ESM, TypeScript, and more #465

Merged
merged 19 commits into from
Sep 18, 2022
Merged

Version 3.0: ESM, TypeScript, and more #465

merged 19 commits into from
Sep 18, 2022

Conversation

aldeed
Copy link
Collaborator

@aldeed aldeed commented Sep 18, 2022

Highlights

  • Rewritten in TypeScript, includes types in published package
  • Both ESM and CommonJS are published to NPM

Breaking Changes

  • Number.isInteger polyfill is removed. Ensure that your build system polyfills this if you are targeting older browsers.
  • All previously included regular expressions (the SimpleSchema.RegEx object) are no longer included. Some were potential DDoS targets, and all of them were frequent subjects of debate. You may copy-paste the expressions from an old version of this package at your own risk, or use this as an opportunity to implement smarter checks.
  • The message-box dependency, schema.messageBox, and other related functions are removed. See the readme for how to customize error messages.
  • Injecting Meteor Tracker to make some functions reactive is no longer supported
  • SimpleSchema.extendOptions no longer accepts an object as its first argument. This function signature was previously deprecated and is now removed.
  • SimpleSchema._makeGeneric is removed. Use MongoObject.makeKeyGeneric directly.

@aldeed aldeed merged commit cd1a171 into main Sep 18, 2022
@aldeed aldeed deleted the 3.0 branch September 18, 2022 16:48
@longshotlabs longshotlabs deleted a comment from github-actions bot Sep 19, 2022
@lynchem
Copy link

lynchem commented Sep 22, 2022

Injecting Meteor Tracker to make some functions reactive is no longer supported

So that's it, goodbye Meteor? 😢 Or is there a preferred method to handle this now?

@aldeed
Copy link
Collaborator Author

aldeed commented Sep 23, 2022

@theslantedroom I had updated that regEx section along with the release to say that the built-in ones are removed and what to do. If there's another outdated section I'm not seeing let me know.

@lynchem I'm kind of hoping somebody can figure out a good wrapper for the Tracker reactivity. I can update SimpleSchema to emit change events or whatever would be needed for that, but it just was not worth continuing to support that by dependency injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants