-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Explorer does not work in Safari (mixed HTTP/HTTPS content problem) #1603
Comments
Related reading: https://developer.mozilla.org/en-US/docs/Web/Security/Mixed_content
https://stackoverflow.com/questions/32883306/safari-9-disallowed-running-of-insecure-content
I am not sure how to actually fix this problem if Safari does not allow mixed content even on localhost. Perhaps we need to support both |
Does not work on the latest version of Chrome either. |
@virkt25 , do we need to estimate this or should put to backlog directly? |
I think @raymondfeng already has a fix for this in #1608 |
Ah right, forgot the issue goes beyond just not setting the right protocol for the openapi spec file. @dhmlau we should estimate this but for that to happen we need to decide upon a fix. I can think of two options:
EDIT assigned to everyone for further discussion. |
To self-host API explorer UI, I created a PR to enable it: #1611 |
Earlier this week, we discussed this issue with @raymondfeng and @virkt25 and found a solution that should be relatively quick to implement and does not require self-hosted explorer. See the updated acceptance criteria:
|
If you remember my demo, the app which was hosted on a Is this covered by one of the criteria? |
@hacksparrow thanks for raising this concern. I believe the correct handling of protocols is part of the last criteria:
When the app is running on HTTP, then the explorer should redirect to http://explorer.loopback.io. When the app is on HTTPS, then the explorer should redirect to https://explorer.loopback.io. |
Fixed. Now we have API explorer served from:
|
Description / Steps to reproduce / Feature proposal
todo
example applicationCurrent Behavior
Failed to load API definition.
Expected Behavior
API Explorer (swagger UI) is correctly loaded for the explored application.
Please note that both Chrome and Firefox work well.
Acceptance Criteria
~~Verify issue has been resolved once we offer a self-hosted API Explorer #559. If not, re-review this issue with the team. Otherwise close it.~~~
explorer.loopback.io
.loopback.io
repo to a new GH repositoryexplorer.loopback.io
(via GH pages)https://loopback.io/api-explorer
should redirect to the new domainSee Reporting Issues for more tips on writing good issues
The text was updated successfully, but these errors were encountered: