Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use FQIN in Dockerfile #9842

Merged
merged 1 commit into from
Aug 18, 2023
Merged

chore: use FQIN in Dockerfile #9842

merged 1 commit into from
Aug 18, 2023

Conversation

achrinza
Copy link
Member

see: #9841

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@achrinza
chore: use FQIN in Dockerfile
c73ce70 
see: #9841
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5845710429

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.156%
Totals Coverage Status
Change from base Build 5835840895: 0.0%
Covered Lines: 9556
Relevant Lines: 12424
💛 - Coveralls

@achrinza achrinza marked this pull request as ready for review August 13, 2023 08:15
@achrinza achrinza merged commit c5d7fb0 into master Aug 18, 2023
@achrinza achrinza deleted the chore/fqin-dockerfile branch August 18, 2023 11:05
@achrinza achrinza linked an issue Aug 18, 2023 that may be closed by this pull request
Use FQIN in Dockerfile #9841
Open
@coveralls
Copy link

coveralls commented Oct 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 5845710429

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.156%
Totals Coverage Status
Change from base Build 5835840895: 0.0%
Covered Lines: 9556
Relevant Lines: 12424
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

@nabdelgadir nabdelgadir Awaiting requested review from nabdelgadir nabdelgadir is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use FQIN in Dockerfile
3 participants
@achrinza @coveralls @dhmlau