PHP 8 Compatibility

[AlexandruGG]

Currently loophp/collection can be installed in a project running PHP 8, however does not have full compatibility with it.

I started a branch to look into compatibility issues, and good news is the only one that seems to be problematic so far is the asyncMap operation.

I think what we need to do is:

1. enable CI runnning on both php-version 7.4 and 8.0 (easy)
2. fix any static analysis issues (easy)
3. decide what to do about asyncMap and implement plan (medium)

Regarding point 3, here are some thoughts:

• to use that operation requires amphp/parallel-functions, which is a bit like a "hidden" dependency. You only realise you need it at runtime because it will throw an exception, or by reading the documentation of course
• the library it uses does not have PHP 8 support and there don't seem to be any plans to add it. Also, it doesn't look very actively maintained - latest release was in July 2020
• is asyncMap that useful? Surely a nice to have but I imagine very few users actually benefit from it; and those actually using a lot of concurrency in PHP probably won't rely on it because they will already have their own things

This being said, I see a couple of options regarding asyncMap:
A) remove it from the next major version with PHP 8 support. It would still be available for everyone using the library on PHP 7.4
B) keep it in the library but "disable" it for PHP 8 users, i.e. throw a type of LogicException when used. This would be clearly specified in the documentation as well
C) add support and needed logic using a different library for parallelism, like https://github.com/spatie/fork. Note that his one is only available on PHP 8, so we'd have to check the running php version in the AsyncMap operation and use the corresponding library. On a quick search I couldn't find an equivalent package that supports both 7.4 and 8.0.

[AlexandruGG]

@drupol let me know your thoughts on this! 😁

[drupol]

Hi Alex,

We can slowly move on by fixing the 2 first points, then, for the last point, I can discuss with the maintainer (@kelunik) and see how we can update properly.
If we can't get around it, I don't mind removing it in the meantime.

[kelunik]

What makes you think there's no PHP 8 support or no plans to add it? Having no release for a year can also mean it's simply stable.

[AlexandruGG]

by default I see PHPSpec uses 30719 which represents E_ALL

@drupol for our issue I tested and it works with 22525 # E_ALL & ~E_DEPRECATED & ~E_STRICT & ~E_WARNING

[drupol]

I think it's definitely an issue with PHPSpec.
Look, I'm currently working for work and I'm having the same kind of issue, see:

The test can be found here: https://github.com/ecphp/cas-bundle/blob/master/spec/EcPhp/CasBundle/Security/Core/User/CasUserProviderSpec.php#L72

[ciaranmcnulty]

Can we move this to a phpspec issue?

[drupol]

Done! phpspec/phpspec#1375

[AlexandruGG]

phpspec/phpspec#1378 was merged so this is all good now. Thanks for the assistance @kelunik! 🎉