Revert "fixes try_add_state"

This reverts commit 254ad17.

Signed-off-by: Lorenzo Curcio <Lorenzo.curcio@valuecuberesearch.com>

Author: elena-kolevska

dapr/actor/runtime/mock_state_manager.py

@@ -51,7 +51,7 @@ async def try_add_state(self, state_name: str, value: T) -> bool:
                 return True
             return False
         existed = state_name in self._mock_state
-        if existed:
+        if not existed:
             return False
         self._default_state_change_tracker[state_name] = StateMetadata(value, StateChangeKind.add)
         self._mock_state[state_name] = value

dapr/actor/runtime/state_manager.py

@@ -90,7 +90,7 @@ async def try_add_state(self, state_name: str, value: T) -> bool:
         existed = await self._actor.runtime_ctx.state_provider.contains_state(
             self._type_name, self._actor.id.id, state_name
         )
-        if existed:
+        if not existed:
             return False
 
         state_change_tracker[state_name] = StateMetadata(value, StateChangeKind.add)

tests/actor/test_mock_state_manager.py

@@ -46,7 +46,7 @@ def setUp(self):
 
     @mock.patch(
         'tests.actor.fake_client.FakeDaprActorClient.get_state',
-        new=_async_mock(),
+        new=_async_mock(return_value=base64.b64encode(b'"value1"')),
     )
     @mock.patch(
         'tests.actor.fake_client.FakeDaprActorClient.save_state_transactionally', new=_async_mock()
@@ -67,20 +67,6 @@ def test_add_state(self):
         added = _run(state_manager.try_add_state('state1', 'value1'))
         self.assertFalse(added)
 
-    @mock.patch(
-        'tests.actor.fake_client.FakeDaprActorClient.get_state',
-        new=_async_mock(return_value=base64.b64encode(b'"value1"')),
-    )
-    @mock.patch(
-        'tests.actor.fake_client.FakeDaprActorClient.save_state_transactionally', new=_async_mock()
-    )
-    def test_add_state_with_existing_state(self):
-        state_manager = ActorStateManager(self._fake_actor)
-
-        # Add first 'state1'
-        added = _run(state_manager.try_add_state('state1', 'value1'))
-        self.assertFalse(added)
-
     @mock.patch('tests.actor.fake_client.FakeDaprActorClient.get_state', new=_async_mock())
     def test_get_state_for_no_state(self):
         state_manager = ActorStateManager(self._fake_actor)