Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for load multiple files by values defined in NODE_ENV #486

Merged
merged 2 commits into from
May 31, 2018
Merged

Add support for load multiple files by values defined in NODE_ENV #486

merged 2 commits into from
May 31, 2018

Conversation

leonardovillela
Copy link
Contributor

@leonardovillela
Copy link
Contributor Author

Hello Guys, any problem with this PR? I can help with something?

@lorenwest
Copy link
Collaborator

Thank you for your patience - I've been pretty busy lately.

lorenwest
lorenwest reviewed May 31, 2018
View reviewed changes
test/14-config/bare-metal.json
"db": {
"name": "bare-metal-config-env-provided"
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've removed the final newline in these files. Could you un-do those changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i will update this

@lorenwest
Copy link
Collaborator

This looks good - thank you for adding this feature. Only one comment in the code review - if you could undo those newline removals and re-issue the PR, I'll get it merged.

@lorenwest lorenwest merged commit 66bd8e1 into node-config:master May 31, 2018
@lorenwest
Copy link
Collaborator

@leonardovillela - We are having a conversation on #484 regarding including this in a major version bump. Will get this published as soon as we conclude that version bump issue.

@lorenwest lorenwest mentioned this pull request Nov 20, 2018
Merged
@KrishnaPG
Copy link

Would default be still loaded in case multiple env are specified?

@markstos
Copy link
Collaborator

markstos commented May 5, 2021

I noticed the wiki was never updated to reflect this change. Documenting it now.

@Centaurioun Centaurioun mentioned this pull request Dec 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenwest lorenwest lorenwest left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leonardovillela @lorenwest @KrishnaPG @markstos