Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong variable description and example #21

Closed
Krad-dono opened this issue Sep 12, 2023 · 1 comment
Closed

wrong variable description and example #21

Krad-dono opened this issue Sep 12, 2023 · 1 comment
Assignees

Comments

@Krad-dono
Copy link

Krad-dono commented Sep 12, 2023

So I used this module to provision database alarms as per example. It did not work - all alarms were stuck in Insufficient data state. I did raise a case to AWS support so they looked at my alarms and identified that database ID was used where Identifier need to be used. This is for RDS SQL Server at least.
Your example says:
db_instance_id = aws_db_instance.default.id
Should be:
db_instance_id = aws_db_instance.default.identifier
Please amend documentation accordingly.

@dudeitssm
Copy link

To add some more context, and to help out newbie Terraform users puzzled by this issue, here's what that means...

Example: I have a single node RDS cluster, example-rds with a writer node.
The correct value that has to be substituted within the db_instance_id = input would be db_instance_id = example-db-1 and not example-db.

I've also attached a screenshot to show what that means.

The green checkmark is the value you want substituted.
The red cross is what's currently happening in the repo provided example.

example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants