Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino framework 3.5.0 vfs_api change #52

Open
vojmar opened this issue Jul 2, 2022 · 1 comment
Open

Arduino framework 3.5.0 vfs_api change #52

vojmar opened this issue Jul 2, 2022 · 1 comment

Comments

@vojmar
Copy link

vojmar commented Jul 2, 2022

In the newly released Arduino framework the vfs_api.h open functions header changes such that it takes a mandatory additional parameter.
FileImplPtr open(const char* path, const char* mode, const bool create) override;
This caused a problem in LITTLEFS.cpp line 44 where third parameter is not provided.

Suggested fix

By providing third parameter as false the file should not be created when checking with exist function.
Please verify and implement, also make sure its not breaking the older versions.

@juandelacruz-calvo
Copy link

I wish they would have made the parameter optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants