Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to language service extensions, so they support GistPad (e.g. Prettier) #30

Closed
5 of 9 tasks
lostintangent opened this issue Dec 1, 2019 · 9 comments
Closed
5 of 9 tasks
Labels
area: editor bug Something isn't working external

Comments

@lostintangent
Copy link
Owner

lostintangent commented Dec 1, 2019

@lostintangent lostintangent added enhancement New feature or request external labels Dec 1, 2019
@xavxyz
Copy link

xavxyz commented Dec 12, 2019

👋, hey there!

Just discovered GistPad, this extension is excellent! And I'd love to be able to use Prettier with it.

Can I help on this feature? Any recommendations on where to start?

@xavxyz
Copy link

xavxyz commented Dec 12, 2019

... I had the feeling Prettier wasn't running, but it seems to work now! 😅

Screencast:
Screen Recording 2019-12-12 at 04 38 PM

@lostintangent
Copy link
Owner Author

Hmm, that’s unexpected actually! Let me try this and see if Prettier works in a Gist file for me as well 😁 I was expecting to need to send a PR to that extension in order to enable it for this scenario (which should be a fairly simple change).

@lostintangent
Copy link
Owner Author

FYI, I just sent a PR to VS Code to enable Markdown and Emmet in Gist-backed files: microsoft/vscode#87541.

@xavxyz
Copy link

xavxyz commented Jan 2, 2020

Excellent!

@franklin-ross
Copy link

Just created an issue in the spell checker I use, which I'm guessing is also related to this. Would be great to have it supported too! I didn't realise how much I relied on spell checking in Markdown files until it was gone.

@lostintangent
Copy link
Owner Author

@franklin-ross Thanks! I just took a quick look at the spell checker’s code, and it’s possible that this would be an easy fix. I’ll see if I can try it out and send a PR tomorrow 👍

@franklin-ross
Copy link

franklin-ross commented Apr 20, 2020

Wow, that's great, thanks a lot! Impressively quick response time there!

@lostintangent
Copy link
Owner Author

@franklin-ross PR is out: streetsidesoftware/vscode-spell-checker#469.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: editor bug Something isn't working external
Projects
None yet
Development

No branches or pull requests

3 participants