Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What code raises RetriableResponse? #8

Open
jcoyne opened this issue Mar 1, 2022 · 2 comments
Open

What code raises RetriableResponse? #8

jcoyne opened this issue Mar 1, 2022 · 2 comments

Comments

@jcoyne
Copy link

jcoyne commented Mar 1, 2022

I see that it is handled by this middleware, but what code raises it?

@jcoyne jcoyne changed the title What raises RetriableResponse What code raises RetriableResponse? Mar 1, 2022
@olleolleolle
Copy link
Member

No library code, but perhaps your application code could raise that error, when you wanted to?

https://github.com/search?q=org%3Alostisland+RetriableResponse&type=code

@jcoyne
Copy link
Author

jcoyne commented Mar 3, 2022

I wonder if this should be removed from the Retry::Middleware::DEFAULT_EXCEPTIONS. It's more straightforward to just pass the exceptions one wants to rescue to the middleware.

The approach of having a retriable exception made sense in Faraday 1.0, when it was actually used by exceptions that were retriable, but now it seems unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants