Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[groups] Dependent monitoring of hierarchical monitors #1089

Open
1 task done
Bark33p3r opened this issue Dec 22, 2021 · 12 comments
Open
1 task done

[groups] Dependent monitoring of hierarchical monitors #1089

Bark33p3r opened this issue Dec 22, 2021 · 12 comments
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:new proposing to add a new monitor

Comments

@Bark33p3r
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

Hello there,

may it's possible to create a parent (internet connection) and children (server behind this router).
I always get a bunch of service notifications when the internet is down.

✔️ Solution

I would like to create a parent group (Starlink and AT&T e.g.), so when the internet connection should be down, I only get one message for the internet Service and not for my 20 servers running, which aren't reachable due to the internet connection.

❓ Alternatives

No response

📝 Additional Context

Anyway, great tool, Thanks a lot!

@Bark33p3r Bark33p3r added the feature-request Request for new features to be added label Dec 22, 2021
@maddingamer

This comment was marked as spam.

@stelle007

This comment was marked as spam.

@marcbria
Copy link

I don't know why this feature request is so underrated and why anybody though in this before.

I mean, UK is great but, anybody using UK over a single host, would like to get a single notification (instead of one for each service) every time you restart the host or in case you have a massive collapse of your server.

Make a lot of sense to create a "canary" service and get a single notification instead of 20 notifications of the group.

Thanks to report @Bark33p3r

@stelle007

This comment was marked as spam.

@karelkryda
Copy link
Contributor

Hi,
I did some changes yesterday and it looks similar to your request.
Should I add another functionality to my pull request?

@stelle007
Copy link

Hi, I did some changes yesterday and it looks similar to your request. Should I add another functionality to my pull request?

That looks amazing. Looking forward to getting it implemented.

This was referenced Mar 31, 2022
@koen20 koen20 mentioned this issue Nov 20, 2022
1 task
@julian-piehl julian-piehl mentioned this issue Jan 28, 2023
7 tasks
@CommanderStorm
Copy link
Collaborator

@Bark33p3r #2693 has beeen merged and is avaliable in 1.22.
I think this issue is resoved. Could you give feedback if something is missing or close this issue?

@karelkryda
Copy link
Contributor

karelkryda commented Jul 4, 2023

@Bark33p3r #2693 has beeen merged and is avaliable in 1.22. I think this issue is resoved. Could you give feedback if something is missing or close this issue?

Grouping monitors is definitely good if you want, for example, to unify several instances of the same service under one or to categorize services. But I don't think that creating a group containing a monitor that checks the state of the Internet and other servers is what we want. I think my PR (#1236) creating a dependency relationship with another monitor is what a lot of people will want to use to deal with spam during an internet outage. So for me #2693 is definitely useful, but it's not a solution to this issue.

@DANW999
Copy link

DANW999 commented Jul 2, 2024

Are there any plans to implement this at all? I have mentioned before on #1236 that the selection of dependent monitors would be a very useful feature and I am not quite sure why this never saw fruition.

It's not ideal to be alerted about every single item that has gone down behind say a reverse proxy or an internet connection, you just want to know that its the reverse proxy or internet connection itself that has gone down.
As it has been mentioned, grouping monitors does not fix this issue, because all you know then is something in the group has gone down but not what. This is quite an important feature in my opinion.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jul 2, 2024

Are there any plans to implement this

I don't know of current plans to implement this (as in: somebody is actively implementing this).
If/somebody else you want to contribute such a feature, our contribution guide is here.
Make sure to rebase any changes in this area on top of #4395 to minimise merge conflicts like the one that killed #1236

I am not quite sure why this never saw fruition

See #2693 (comment) if you are interested in the history of groups v dependent monitors.

TL;DR: #1236 got hung up on a review, then groups were added and caused a large merge/feature conflict.

@gene1wood

This comment has been minimized.

@CommanderStorm

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants