Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong datatype error #1577

Closed
2 tasks done
Goldenflamer opened this issue Apr 27, 2022 · 3 comments
Closed
2 tasks done

Wrong datatype error #1577

Goldenflamer opened this issue Apr 27, 2022 · 3 comments
Labels
bug Something isn't working priority:high High Priority

Comments

@Goldenflamer
Copy link

Goldenflamer commented Apr 27, 2022

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

There is an error causing a problem when saving certain values. Even if the datatype of the input is correct, there is an error saying "Wrong Datatype?" The error appears most consistently when adding a Steam API key via the settings but I have also seen it with other values. I am using the No Auth mode if that matters,

Steam key has the form A89A....... and is copied and pasted from steam directly, so it is 100% correct.

👟 Reproduction steps

Go to Settings and add a Steam API key
After inserting the Steam API key press save buttton

👀 Expected behavior

Steam API Key should be saved

😓 Actual Behavior

Error popup saying "Wrong data type?"

🐻 Uptime-Kuma Version

1.15.0

💻 Operating System and Arch

Windows 10 21H2 newest Updates as of posting date

🌐 Browser

Google Chrome 101.0.4951.41 64 bit

🐋 Docker Version

Docker Standalone 20.10.14

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@Goldenflamer Goldenflamer added the bug Something isn't working label Apr 27, 2022
@chakflying
Copy link
Collaborator

chakflying commented Apr 27, 2022

Saw this too, I think there is a bug with the authentication code when using No Auth mode, but I'm not sure exactly what's going on. Please try to enable auth and login again and the problem should go away.

@Goldenflamer
Copy link
Author

Saw this too, I think there is a bug with the authentication code when using No Auth mode, but I'm not sure exactly what's going on. Please try to enable auth and login again and the problem should go away.

Yep you are right, working fine with auth

@Goldenflamer
Copy link
Author

Goldenflamer commented Apr 27, 2022

The problem is that doubleCheckPassword(socket, currentPassword) is called when auth is disabled which should not be the case. There is only one occurrence where there is a check before it if authentication is disabled, maybe the check could be added to other occurrences as well. Or maybe the check is not working properly.

@louislam louislam added the priority:high High Priority label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High Priority
Projects
None yet
Development

No branches or pull requests

3 participants