Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Atom (RSS) feed for notifications (including the public) #1673

Closed
1 task done
JacksonChen666 opened this issue May 22, 2022 · 6 comments · Fixed by #5047
Closed
1 task done

An Atom (RSS) feed for notifications (including the public) #1673

JacksonChen666 opened this issue May 22, 2022 · 6 comments · Fixed by #5047
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added

Comments

@JacksonChen666
Copy link

JacksonChen666 commented May 22, 2022

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification

🔖 Feature description

Add RSS/Atom feeds as a way of notifications.

✔️ Solution

Add a new notification method (RSS/Atom feeds).

Also, add an option of which feed should correspond to a status page on when modifying the status page.

❓ Alternatives

No response

📝 Additional Context

Some examples of real world use:

@JacksonChen666 JacksonChen666 added the feature-request Request for new features to be added label May 22, 2022
@Rhaal
Copy link

Rhaal commented Sep 22, 2022

@louislam , quick question! Would you be willing to consider merging a PR for this issue if one was available ?

@JacksonChen666
Copy link
Author

JacksonChen666 commented Sep 22, 2022

@louislam , quick question! Would you be willing to consider merging a PR for this issue if one was available ?

@Rhaal this does not feel like a necessary question, except for the case for if the maintainer is OK with a feature like that.

there also seems to be a lot of positive reactions/support on my issue, so at least some people are likely looking for this feature.

i suggest that you start working on it, create a draft PR, and include resolves #1673 somewhere in the description so that merging the PR closes this issue and this issue links to that PR (feature doc).

@Rhaal
Copy link

Rhaal commented Sep 26, 2022

@JacksonChen666, makes perfect sense! Thanks for the pointers, I had tagged Louis simply to get a suggestion on how I could help on the subject at hand - and I'd say your proposal is the best course of action, in the worst case it's just a draft PR to discard.
Thanks!

@louislam
Copy link
Owner

Yes, better discuss before work, Uptime Kuma's pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

I usually accept notification pull requests, but how RSS could be a notification type in Uptime Kuma? It is because for most current notification providers such as Telegram, it makes a request to Telegram API in order to send a notification. However, RSS is just a xml, it doesn't seem to be a notification type in my opinion.

@JacksonChen666
Copy link
Author

JacksonChen666 commented Sep 26, 2022

@louislam RSS feeds are more of a "pull" model (client periodically pulls information), and the current notification in uptime kuma is more of a "push" model (server sends a notification which is pushed to the client).

i think i'm starting to see this idea fall apart.

however, instatus provides an RSS/Atom feed, and i have added sponsorblock status to my RSS feeds.

@Rhaal
Copy link

Rhaal commented Sep 27, 2022

Hi everyone - absolutely agreed, and thanks for taking the time to point me to the Contribution guidelines - I really should have read them beforehand!
I've opened the PR for discussion, and I do acknowledge your concerns are super-valid; however I'd say RSS is just another kind of view apart from HTML, used by clients that conveniently have periodic polling built within them. If you both agree I'd move the discussion on the feasibility to the draft PR as to not pollute the issue.

@louislam louislam linked a pull request Sep 27, 2022 that will close this issue
7 tasks
@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added
Projects
None yet
4 participants