Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connections are not cleared #2900

Closed
2 tasks done
tico24 opened this issue Mar 8, 2023 · 0 comments · Fixed by #2907
Closed
2 tasks done

Redis connections are not cleared #2900

tico24 opened this issue Mar 8, 2023 · 0 comments · Fixed by #2907
Labels
bug Something isn't working

Comments

@tico24
Copy link

tico24 commented Mar 8, 2023

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

When using a redis monitor, it appears to create a new connection every time it runs a ping, and it does not clear old connections out.

image

image

In the grafana graph, I set up the Uptime Kuma connection just before 16:00 and left it running overnight. By the morning, uptime-kuma was holding 1000 connections to redis. I terminated the uptime kuma pod and the connections immediatelly dropped (shown at approx 07:00), before climbing again.

Pausing the redis monitor is not enough to free up the connections. I have to restart the uptime-kuma pod to achieve this.

👟 Reproduction steps

Set up a redis monitor and leave it running for 24h.

👀 Expected behavior

The pings are frequent enough that I would expect them to use the same connection each time. But at a minimum, older connections should be closed gracefully.

😓 Actual Behavior

Uptime Kuma creates a new connection every time it runs a ping, and it does not clear old connections out.

🐻 Uptime-Kuma Version

1.20.0

💻 Operating System and Arch

Amazon linux 2

🌐 Browser

Firefox 109.0.1

🐋 Docker Version

EKS 1.24

🟩 NodeJS Version

n/a

📝 Relevant log output

I could not find any relevant logging.
@tico24 tico24 added the bug Something isn't working label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant