Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications via RingCentral #2967

Open
1 task done
lordmofisto opened this issue Mar 23, 2023 · 4 comments
Open
1 task done

Notifications via RingCentral #2967

lordmofisto opened this issue Mar 23, 2023 · 4 comments
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added type:new proposing to add a new monitor

Comments

@lordmofisto
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification

🔖 Feature description

For the purposes of RingCentral Incoming Webhook integration, the JSON is not properly formatted in order to work with their service.

See Documentation: https://developers.ringcentral.com/guide/team-messaging/incoming-webhooks/posting

Testing the notification yields a positive result leaving Uptime-Kuma but it's rejected at the hooks.ringcentral.com URL because it's not properly formatted.

✔️ Solution

I suspect that not every webhook provider will implement in the same way I am requesting a RingCentral Notification webhook feature be added.

❓ Alternatives

I attempted to change the webhooks code itself to properly post, which worked, however since I am not familiar with all the inner workings of the project, I was only able to post static data, and not the desired notifications that are offered like heartbeat, monitor, msg...

📝 Additional Context

No response

@lordmofisto lordmofisto added the feature-request Request for new features to be added label Mar 23, 2023
@chakflying
Copy link
Collaborator

{
  "text": msg
}

I think just setting this in the Webhook Notification Provider would be a good starting point. Beyond that, you can get the monitor name and other info from monitorJSON, and get the current event status from heartbeatJSON.status.

@lordmofisto
Copy link
Author

{
  "text": msg
}

I think just setting this in the Webhook Notification Provider would be a good starting point. Beyond that, you can get the monitor name and other info from monitorJSON, and get the current event status from heartbeatJSON.status.

I get an error that says that is not a valid JSON format.

If I open the docker container's console for Uptime-Kuma, install CURL and do a curl -X POST -H "Content-Type: application/json" -d '{"text":"Hello, World!"}' https://hooks.ringcentral.com/webhook/v2/MyWebhookKey

The message goes through, so I know my network is working properly.

If I put the {"text":"Hello, World!"} in the additional headers, and hit test, I get a successful notification in the browser window, but nothing comes through to my incoming webhook.

Looking at the logs for the Docker container all I see are host errors for when a host isn't responding to pings. I don't see anything about webhooks successfully or unsuccessfully sending. Where would I look for those errors?

@CommanderStorm

This comment was marked as off-topic.

@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Dec 5, 2023
@CommanderStorm CommanderStorm changed the title RingCentral Integrated Webhook Notifications via RingCentral Dec 5, 2023
@CommanderStorm
Copy link
Collaborator

#3084 includes some code for how to set up a RingCentral monitor.
If someone would like to propose this as a new notification provider, please follow the pathway laid out here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md
See #2980 for a successful example of the required Pull Request.

@CommanderStorm CommanderStorm added the type:new proposing to add a new monitor label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added type:new proposing to add a new monitor
Projects
None yet
Development

No branches or pull requests

3 participants