Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Http probe #3336

Closed
1 task done
mabed-fr opened this issue Jun 29, 2023 · 1 comment · May be fixed by #3919
Closed
1 task done

Merge Http probe #3336

mabed-fr opened this issue Jun 29, 2023 · 1 comment · May be fixed by #3919
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added

Comments

@mabed-fr
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

API, New Monitor, UI Feature

🔖 Feature description

Today we have 2 http probes and a third one being prepared #1878

It is quite possible to merge into one.

✔️ Solution

Combine 3 probes in one

HTTP with

  • keyword field (empty by default)
  • response time field (10s by default)
  • return status code field (default return code already present 200-299)

❓ Alternatives

No response

📝 Additional Context

This would make it possible not to multiply the probes to cover all the functionalities
@mabed-fr mabed-fr added the feature-request Request for new features to be added label Jun 29, 2023
@chakflying chakflying mentioned this issue Oct 19, 2023
Draft
7 tasks
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Dec 5, 2023
@CommanderStorm CommanderStorm added the type:new proposing to add a new monitor label Dec 13, 2023
@CommanderStorm CommanderStorm mentioned this issue Dec 14, 2023
Closed
1 task
@CommanderStorm CommanderStorm removed the type:new proposing to add a new monitor label Dec 14, 2023
@CommanderStorm
Copy link
Collaborator

I think this work is better tracked in #3919 and I don't really see the point of having another issue open for this refactoring ^^
=> closing as a "duplicate"

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proposal: Make Keyword & Json-Query generic across monitor types chakflying/uptime-kuma
2 participants
@mabed-fr @CommanderStorm