Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubt/Help;Bug;Suggestion #4013

Closed
superen7527 opened this issue Nov 11, 2023 · 11 comments
Closed

Doubt/Help;Bug;Suggestion #4013

superen7527 opened this issue Nov 11, 2023 · 11 comments
Labels

Comments

@superen7527
Copy link

superen7527 commented Nov 11, 2023

很抱歉我不太懂英语所以没有搜索issue但是我看到最新的open issue和我的3很像。我只是想把想法告诉你,但是不太会提交issue见谅。

I'm sorry I don't know much English so I didn't search for issue but I see that the latest issue is very similar to my 3. I just want to tell you the idea, but not very good at submitting issues sorry.


我认为这个排版比较乱开了空白但是被关闭只能出此下策

I think this typography is rather messed up opening the blanks but being shut down is the only way out


1.修改时区,但是界面多个地方显示的还是0时区,比如维护。

2.使用webhook作为通知,我找不到相关文档介绍json的参数 比如 heartbeatJSON 和 monitorJSON 只有示例的一个name。另外建议不要使用 hint 作为提示 会无法复制。

3.通知会把所有状态通知,希望可以设置 失败或者成功 或者特征符合才通知 而不是默认每次都通知。

4.对应http关键词匹配,建议增加匹配类型。比如多个关键词 分组匹配 以及 or/and/! 之类的语义。当然能支持正则更好。也可以解析XML作为部分固定关键词监控或者 区域dom监控 文本截取范围监控。

  1. change the time zone, but the interface still shows 0 time zone in many places, such as maintenance.

  2. use webhook as notification, I can't find any documentation about json parameters such as heartbeatJSON and monitorJSON, only a name for example, and I suggest not to use hint as hint, it won't be able to be copied. 3. notification will notify all statuses, I hope to set failure or success or feature match to be notified, instead of default to notify every time.

  3. notification will notify all statuses, I hope it can be set to notify only when failure or success or feature match instead of default notification every time.

  4. For http keyword matching, it is suggested to increase the matching type. Such as multiple keywords, group matching, and or/and/! or/and/! Of course, it's better to support regularization. You can also parse XML as part of the fixed keyword monitoring or regional dom monitoring text interception range monitoring.

Translated with www.DeepL.com/Translator (free version)

@superen7527 superen7527 added the feature-request Request for new features to be added label Nov 11, 2023
@CommanderStorm
Copy link
Collaborator

First of all:
Please only open one issue per issue, otherwise this is even harder to handle, as this leads to zombie issues.
Currently, this issue is very likely not going to lead anywhere because it is not focused on any issue.

Regarding the issues you mentioned:

  1. Please post an annotated screenshot of what you are referring to. (From the translation it is not clear to me what you mean)
  2. a slightly improved documentation was merged in chore:Webhook custom documentation #3636 and will be released in the v2 milestone. If this updated doc is not clear: how would you document this?
  3. Filter Alerts for Notification  #3585
    • multiple keywords This was orginally attempted in Feature/monitor checks #518, but that attempt failed. Maybe Proposal: Make Keyword & Json-Query generic across monitor types #3919 will result in such a feature. Currently, you will need to use monitor groups to get such a result
    • group matching Are you refering to monitor groups?
    • or/and/! or/and/! Please refer to the issues linked to Selection of dependent monitors #1236
    • Of course, it's better to support regularization Unclear what you mean by regularization Please open an issue in which you explain how this should work exactly and what features would be important
    • You can also parse XML as part of the fixed keyword monitoring Please open an issue in which you explain how this should work exactly and what xml-features would be important
    • regional dom monitoring text interception range monitoring likely https://changedetection.io/ is a better fit

For all the above issues the same holds true: we are a community driven project => here is our contribution guide: https://github.com/louislam/uptime-kuma/blob/5b6522a54edad9737fccf195f9eaa25c6fb9d0f6/CONTRIBUTING.md

@CommanderStorm CommanderStorm added help and removed feature-request Request for new features to be added labels Dec 3, 2023
@superen7527
Copy link
Author

superen7527 commented Dec 12, 2023

抱歉这么久才回复,因为我不太会用github没收到通知.同时无法通过翻译理解你的部分意思 一直想着要回复却没有时间整理清楚 今天我熬夜了两个小时专门处理这个issue(网络问题(我无法使用打开github相关网页以及上传图片)和翻译问题(无法理解一些引用链接的意义)导致的)希望不要怪我回的太晚

我原来打算分开4个issue重新发布引用到这里 但是感觉问题太小 分开又有点大动干戈.这样会浪费你们的时间精力.

现在重新查看需求 我只提一个建议 希望维护界面可以自动使用显示的时区 当然我看到了可以使用服务器时区.我希望可以自动使用显示时区因为有时候两个时区不同

关于2 我无法显示#3636 这是我的界面 为此切换英文界面 还是没有介绍 不过我已经通过#3636 了解了

关于3 可以合并#1233

关于4 我还无法清楚明白你的意思 等我理解以后 如果还有必要我会再开一个issue引用过来

那么 在你决定是否采纳我的建议后就可以正常关闭issue了


Sorry for taking so long to reply, as I'm not very good with github and didn't get the notification. I've been thinking about replying but haven't had the time to organize it, and today I stayed up for two hours working on this issue (network problems (I couldn't open the github page and upload images) and translation problems (I couldn't understand some of the references)) so I hope you don't blame me for replying too late.

I was going to split the 4 issues and repost the references here, but I felt the problems were too small and splitting them would be a bit of a big deal. It would be a waste of your time and energy.

Now that I've revisited the requirements, I'd like to make just one suggestion I'd like the maintenance screen to automatically use the display timezone, but of course I've seen that the server timezone can be used. Of course I see that the server timezone can be used. I would like the display timezone to be used automatically because sometimes the two timezones are different.
image

image
image
Regarding 2, I can't get #3636 to show up, it's my interface, so I switched to English for that, and it still doesn't show up, but I've already found out about it with #3636

image

Regarding 3, it is possible to merge #1233

Regarding 4, I don't know what you mean yet, but when I understand it, I'll open another issue and quote it if I need to.

Then you can close the issue normally after you've decided whether or not to take my advice.

I'd like the maintenance screen to automatically use the display timezone, but of course I've seen that the server timezone can be used. Of course I see that the server timezone can be used. I would like the display timezone to be used automatically because sometimes the two timezones are different.

Translated with DeepL.com (free version)

@superen7527
Copy link
Author

原来是我的翻译插件有问题 现在我看明白了第四点 也可以进行回复

dom需求不大 只是觉得可以和get结合锦上添花
主要的需求有两个1 更多匹配规则 2 添加匹配组合

1.目前看来已经有相关issue 不过希望添加正则表达式作为条件
2.目前好像只能通过组来组合 如果可以 更希望作为条件语句在一个监控里

如果会考虑 那么这个issue可以以这个为需求存在 看你的意愿 可以修改我的标题 我不知道怎么样让他们更得体


It turned out to be a problem with my translation plugin Now that I see the fourth point I can also make a reply

I don't need much dom, but I just thought it would be nice to combine it with get.
There are two main requirements: 1 more matching rules 2 add matching combinations

  1. There seems to be an issue with this already, but I would like to add regular expressions as conditions.
  2. at the moment, it seems that we can only combine them in groups, but if we can, we'd prefer to do it as a conditional statement in a monitor.

If it will be considered, then this issue can exist with this as a requirement, depending on your wishes, and you can change my title, I don't know how to make them more appropriate.

@louislam
Copy link
Owner

謝謝你的建議,一般來說,我們希望一個 Issue = 一個建議/問題/錯誤報告。並且我們有指定格式的,提交時不應刪除該格式。

如果你找到相關建議,可以在該建議點一下讚(👍),以增加該建議的關注度。如有補充,可以在該建議留言。

@superen7527
Copy link
Author

superen7527 commented Dec 12, 2023

If this updated doc is not clear: how would you document this?

抱歉 我不是说你的文档不清楚 我只是没找到文档 请原谅我的英语水平比较差到现在才刚看明白你的意思 .

我只是没找到api 文档 介绍webhook的具体参数含义结构和所有参数 而不是说你的文档不清楚 我没有恶意 这是两种东西 在翻译的时候可能变成了同一个单词造成了误会 我也不是程序员可能不清楚文档应该常在的位置 也看不太明白https://github.com/louislam/uptime-kuma/milestone/24 我对github的机制也了解的不到位 十分抱歉 因为我对github有所欠缺的熟练度给你带来了不好的心情和误会 我只是想提交建议和想法


I'm sorry, I didn't mean to say that your documentation is not clear, I just didn't find it. Please forgive me for my poor English, I've only just understood what you're trying to say.

I just didn't find the "api documentation" which describes the structure of the webhook parameters and all the parameters, not that your documentation is not clear. I don't mean to be mean, it's two different things, but when translating, the same word might have been used and caused a misunderstanding. I'm not a programmer, so I might not be aware of where the documentation should be, and I don't understand it very well. I don't know github's mechanics very well, and I'm sorry for the bad feelings and misunderstandings I've caused you because of my lack of proficiency in github. I'm just trying to submit suggestions and ideas.

@superen7527
Copy link
Author

superen7527 commented Dec 12, 2023

謝謝你的建議,一般來說,我們希望一個 Issue = 一個建議/問題/錯誤報告。並且我們有指定格式的,提交時不應刪除該格式。

如果你找到相關建議,可以在該建議點一下讚(👍),以增加該建議的關注度。如有補充,可以在該建議留言。

好的 我只是觉得那个格式有点乱 我的想法是

1.目前看来已经有相关issue 不过希望添加正则表达式作为条件
2.目前好像只能通过组来组合 如果可以 更希望作为条件语句在一个监控里

算了那我再开一个issue吧

@superen7527
Copy link
Author

謝謝你的建議,一般來說,我們希望一個 Issue = 一個建議/問題/錯誤報告。並且我們有指定格式的,提交時不應刪除該格式。

如果你找到相關建議,可以在該建議點一下讚(👍),以增加該建議的關注度。如有補充,可以在該建議留言。

抱歉问个题外话 你是国人吗 我看你在香港 这样的话我就可以用正常语气交流发布issue 而不用模拟倒装句这里的英语习惯语法

感觉自己有点傻 机翻了半天作者原来是国人看得懂中文哈哈 不过也有点激动有一种他乡遇故知的感觉 在这里看到中文回复有点亲切

@louislam
Copy link
Owner

英文實在不行的話,只寫中文也可以。因為中英同時出現反而更亂。

參考這個: #4172

@louislam
Copy link
Owner

謝謝你的建議,一般來說,我們希望一個 Issue = 一個建議/問題/錯誤報告。並且我們有指定格式的,提交時不應刪除該格式。
如果你找到相關建議,可以在該建議點一下讚(👍),以增加該建議的關注度。如有補充,可以在該建議留言。

抱歉问个题外话 你是国人吗 我看你在香港 这样的话我就可以用正常语气交流发布issue 而不用模拟倒装句这里的英语习惯语法

感觉自己有点傻 机翻了半天作者原来是国人看得懂中文哈哈 不过也有点激动有一种他乡遇故知的感觉 在这里看到中文回复有点亲切

是的,香港人。雖然不會寫簡體中文,也不懂說普通話,但看得懂。

@superen7527
Copy link
Author

英文實在不行的話,只寫中文也可以。因為中英同時出現反而更亂。

參考這個: #4172

这个我看过 我还以为是一个学习例子 结果根本没有详细的描述 反而觉得他在做伸手党 只提要求又不想浪费他自己的时间反而浪费了你们的时间

我以为放上原文 就不会丢失原意 方便两国人一起看 原来会更乱

那我新发布的issue 就用这个引用吧 应该没有太大问题我机翻读的也通顺

I don't need much dom, but I just thought it would be nice to combine it with get.
There are two main requirements: 1 more matching rules 2 add matching combinations

1.There seems to be an issue with this already, but I would like to add regular expressions as conditions.
2.at the moment, it seems that we can only combine them in groups, but if we can, we'd prefer to do it as a conditional statement in a monitor.

@CommanderStorm
Copy link
Collaborator

Regarding 2, I can't get #3636 to show up

This PR will be included in the next release (see the v2.0-milestone for further details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants