Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using slack Username is missing the necessary helptext to explain what it does #4560

Closed
1 task done
ojbkxiongdei opened this issue Mar 7, 2024 · 8 comments · Fixed by #5259
Closed
1 task done
Labels
area:notifications Everything related to notifications bug Something isn't working good first issue Good for newcomers help wanted May need your help to test or answer type:enhance-existing feature wants to enhance existing monitor

Comments

@ojbkxiongdei
Copy link

ojbkxiongdei commented Mar 7, 2024

📑 I have found these related issues/pull requests

Using slack webhook and filling in the user ID or name, the @ corresponding person cannot be alerted.

🛡️ Security Policy

Description

varaint1 varaint2
image image

👟 Reproduction steps

Refer to the 2 pictures above

👀 Expected behavior

I hope slack alerts will be sent to specified users

😓 Actual Behavior

Filling in the slack user parameters does not take effect, and the actual alarm is not sent to the user.

🐻 Uptime-Kuma Version

1.23.11

💻 Operating System and Arch

k8s

🌐 Browser

chrome

🖥️ Deployment Environment

  • Runtime: k8s
  • Database: local
  • Filesystem used to store the database on: nfs
  • number of monitors:

📝 Relevant log output

no
@ojbkxiongdei ojbkxiongdei added the bug Something isn't working label Mar 7, 2024
@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor labels Mar 7, 2024
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Mar 7, 2024

have you tried just using @... or just ... (without <@>)?

@NiNiyas Given that you have introduced this in #61
How should this field be used?

@NiNiyas
Copy link
Contributor

NiNiyas commented Mar 7, 2024

Hey, I don't use slack anymore, but looking at https://api.slack.com/messaging/sending#impersonation, it seems that it is only for impersonation and not for tagging a user. If you want to tag, I think you need to include the username in the message text itself.

@CommanderStorm CommanderStorm changed the title Using slack webhook and filling in the user ID or name, the @ corresponding person cannot be alerted. Using slack Username is missing the necessary helptext to explain what it does Mar 7, 2024
@CommanderStorm CommanderStorm added help wanted May need your help to test or answer good first issue Good for newcomers labels Mar 7, 2024
@sanjogbhalla16
Copy link

I would love to contribute in this , this is my first time , can you please guide me how to do it

@CommanderStorm
Copy link
Collaborator

Shure ❤️.

Here are the relevant links:

@sanjogbhalla16
Copy link

Thank You @CommanderStorm, for your kind support , please assign this task to me and also label it under hacktoberfest-2024.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Oct 9, 2024

We don't assign people (as impossible for non-contributors and non-issue authors) and that label is not necessary=> I won't add both

@R-HNF
Copy link
Contributor

R-HNF commented Oct 27, 2024

I'll try this!

@R-HNF
Copy link
Contributor

R-HNF commented Oct 27, 2024

I've submitted PR #5259!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications bug Something isn't working good first issue Good for newcomers help wanted May need your help to test or answer type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants