Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with detecting language with 3 letter code #4697

Closed
1 task done
searinminecraft opened this issue Apr 20, 2024 · 3 comments Β· Fixed by #4692
Closed
1 task done

Issue with detecting language with 3 letter code #4697

searinminecraft opened this issue Apr 20, 2024 · 3 comments Β· Fixed by #4692
Labels
area:settings Related to Settings page and application configration bug Something isn't working

Comments

@searinminecraft
Copy link

πŸ“‘ I have found these related issues/pull requests

I don't seem to find any related issue.

πŸ›‘οΈ Security Policy

Description

When the system or web browser is set to a language with three letters (e.g. Filipino, which is fil), it only parses the first two (fi) and would automatically assume it's that language (which is Finnish in this case) and chooses that one instead. Since there is no Filipino translation yet, I would expect it to fall back to English, but not in this case because of the issue.

Screenshot:
image

πŸ‘Ÿ Reproduction steps

As far as I know, only Chromium has the option for the Filipino language, so use that instead if you can

  1. Set the preferred language to Filipino on chrome://settings/languages, make sure its at the very top.
  2. Visit any Uptime Kuma instance, like https://status.codeberg.eu or the demo version provided in the README

πŸ‘€ Expected behavior

Since there is no Filipino translation yet, it should fall back to English

πŸ˜“ Actual Behavior

Uses the Finnish language instead

🐻 Uptime-Kuma Version

1.23.12

πŸ’» Operating System and Arch

Arch Linux

🌐 Browser

Chromium 122.0.6261.111

πŸ–₯️ Deployment Environment

Not applicable

πŸ“ Relevant log output

No response

@searinminecraft searinminecraft added the bug Something isn't working label Apr 20, 2024
@CommanderStorm
Copy link
Collaborator

Who would have thought that language detection is such a hard problem.
You got to be kidding me..

@CommanderStorm CommanderStorm added area:core issues describing changes to the core of uptime kuma area:settings Related to Settings page and application configration and removed area:core issues describing changes to the core of uptime kuma labels Apr 20, 2024
@CommanderStorm CommanderStorm linked a pull request Apr 20, 2024 that will close this issue
7 tasks
@sprior
Copy link

sprior commented Apr 22, 2024

I don't think the problems are solved yet, suddenly uptime is showing the UI in Polish every time I reload when I need English.

@CommanderStorm
Copy link
Collaborator

Unsurprising as the PR that fixed the issue #4692 is not yet released to allow for fixing the proxy/metrics issues at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings Related to Settings page and application configration bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants